Remove the System.Drawing.Common dependency #39108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ViktorHofer
approved these changes
Feb 29, 2024
# Conflicts: # eng/Version.Details.xml
|
fyi, there's a set of dependencies that end up installed to the sdk<version> folder that come from nuget and msbuild. We wanted to transitively pin those to the latest versions. I don't see S.D.C in that list currently in a preview 1 install so this is probably safe to remove...I think. At the time I enabled transitive pinning, I tried to catch every binary I could that was flagged as coming from those two and installing the dependency in with the SDK. |
# Conflicts: # eng/Version.Details.xml
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm told this was added as part of the transitive pinning PR. However, I'm also told that this was because of MSBuild having some kind of legacy dependency on it, but that is no longer the case. So, let's remove it.
CC @marcpopMSFT