Use arcade infra for DEB and RPM build

[NikolaMilosavljevic]

Resolves #43688

This enables SDK to use shared infrastructure for DEB and RPM build. It also uses the latest tooling implemented by @jkoritzinsky which enables us to run the build on containers without special tooling, i.e. FPM/dep-package-tool. I have updated the pipeline to use simple containers.

Previously, there was a simple test that ensured installation of SDK package, along with all of the dependencies. The test had limited value. I have created an issue (epic) to track all improvements around installer testing - dotnet/source-build#4758, as well as package installation - dotnet/runtime#109848

Manpages were never installed with SDK package even though there was some 'code' in the old infra. There was a bug in that code. New shared infrastructure supports manpages but due to a current issue, it does not install them to the correct location. I have created two issues to track relevant fixes:: dotnet/arcade#15243 and #44833

There are some minor differences in metadata contents. It, now, better matches other .NET packages, i.e. those produced by runtime. Tracked with #45126

Testing

Fully tested with internal build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2586841&view=results

[jkoritzinsky]

Generally looks good. Just a few comments around things I'd like to get a little cleaner.

Also, we should be able to delete https://github.com/dotnet/sdk/blob/main/src/Tasks/sdk-tasks/BuildFPMToolPreReqs.cs and files under https://github.com/dotnet/sdk/tree/main/src/Installer/redist-installer/packaging/rpm now

[jkoritzinsky]

Can we move most of this target out of a target and move the "replace file contents" task usage into a target that runs before the GenerateInstallers target when BuildDebPackage is true?

(I'd like to reduce references to the GetDeb/RpmInstallerJsonProperties targets as much as we can)

[NikolaMilosavljevic]

Some of these properties are similarly set in runtime, in the same target, i.e. https://github.com/dotnet/runtime/blob/main/src/installer/pkg/sfx/installers/dotnet-host.proj

I agree that task should be conditioned to run for DEB build only.

I'll check what else can be moved out of this target.

[jkoritzinsky]

Yes, many of them are due to how the old tooling worked and how it was easier to reuse the existing spot.

Other ones are mainly around getting the current installer package version and using that to declare dependencies on other packages.

I'm working on some changes in arcade to make moving the second group out of a target possible.

[NikolaMilosavljevic]

Generally looks good. Just a few comments around things I'd like to get a little cleaner.

Also, we should be able to delete https://github.com/dotnet/sdk/blob/main/src/Tasks/sdk-tasks/BuildFPMToolPreReqs.cs and files under https://github.com/dotnet/sdk/tree/main/src/Installer/redist-installer/packaging/rpm now

Thanks. Yeah, those can be cleaned - will do that.

[NikolaMilosavljevic]

Force pushed to update the branch. Resolved conflicts offline.

[NikolaMilosavljevic]

Addressed few more comments. Removed unused task and conditioned the DEB postinst processing. We can do a follow-up cleanup if needed.

[jkoritzinsky]

If you set <UseBrandingNameInLinuxPackageDescription>true</UseBrandingNameInLinuxPackageDescription> in the property group on the top of the project, you'll get a package summary like Microsoft .NET SDK - 10.0.101 instead of Microsoft .NET SDK 10.0.101 and (in combination with dotnet/arcade#15308) not need this custom target.

[NikolaMilosavljevic]

Hmm, it's worth waiting for arcade to flow to sdk, to be able to utilize that change and get rid of this target.

Or we can do this as a follow-up.

[jkoritzinsky]

I'm fine with either waiting or doing this as a follow-up cleanup.