Define a RepositoryReference to sdk to get the live package sources in the NuGet.config #46330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the NuGet.config
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ViktorHofer
changed the title
jkoritzinsky
approved these changes
Jan 27, 2025
|
Validated offline that this works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#4845
Unblocks #46244
By defining a
RepositoryReferencetosdkin thescenario-tests.projfile, we ensure that theNuGet.configfile in thescenario-testsrepository includes the live package sources from thesdk. This change is necessary to prevent build failures in thewin-x64vertical in an official build with unique versioning.This is conditioned on when not building source-only as in that configuration, the live produced packages shouldn't be used, at least right now. This might change in the future when source-build will also enable unique versioning.
Additionally, stop putting the scenario-tests artifacts outside of the repo, under the VMR artifacts. This is necessary so that the NuGet.config in the repository gets used.