Move project.json dependency completion & hover to vscode-omnisharp

[aeschli]

Until now the code that drove intellisense for dependencies in project.json was sitting in the JSON extension.
We want the omnisharp extension to take ownership.
This pull request implements a completion provider and a hover provider using the newly created 'jsonc-parser' node module that does the JSON file processing.
It gets nuget packages from the nuget API, but is not aware of any nuget configuration files.

In the future the omnisharp extension can also consider to power the completions and hovers directly from the omnisharp server.

We will remove the project.json completion support from the JSON extension for the coming release (end of April).

[aeschli]

Remarks:

• upgrading vscode dependency to 0.11.0 to use the new vscode API CompletionList. Along with that change, adding node ./node_modules/vscode/bin/install to postinstall to always fetch the vscode.d.ts that matches the dependency.
• upgrading typescript to 1.8.9 to use the new export type = "a" | b" syntax that is used in jsonc-parser - d.ts. If you don't like that change, then I can look into not using that syntax in jsonc-parser

[gregg-miskelly]

Master is currently locked down. I will follow up over email.

[aeschli]

Ok, I'll wait with removing our support until your stream is open again.

[aeschli]

Any updates here?

[troydai]

Hi, quick question here. I notice that spaces and tabs are mixed as indents in C# extension source code. Looks like in this PR every indentation is a tab. Just wondering do we have a guideline in place in terms of tab vs spaces? If not, I think it would be nice to settle on one (cough, space, cough).

[troydai]

is it possible to export this value and make it configurable?

[aeschli]

Yes, that would be a future improvement. The feeds to use should probably be picked up from nuget.config

[troydai]

👍 cool.

[aeschli]

@gregg-miskelly Any update here? Please let me know when I can remove the project.json code on the VSCode side...

[aeschli]

@gregg-miskelly @DustinCampbell Any updates here?
Is it ok if I remove our project.json suggest code from VSCode?

[gregg-miskelly]

@DustinCampbell this is more your area, so I will leave this to you.

[DustinCampbell]

@aeschli: Sorry for the delay. This definitely won't merge cleanly, so I'm going to take this week and migrate your changes.

[DustinCampbell]

Closing in favor of #1236.