Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates-dotnet-path-configuration-description #6161

Closed
wants to merge 1 commit into from
Closed

updates-dotnet-path-configuration-description #6161

wants to merge 1 commit into from

Conversation

dandev486
Copy link
Contributor

Changelog

  • Clarifies that the dotnet path must refer to a diretory (and not to the executable)
  • Portuguese translation of the same setting (PT-BR)

Other

Related to #6068, based on the clarification provided by @dibarbet.

@dandev486 dandev486 requested a review from a team as a code owner August 17, 2023 11:46
@dandev486 dandev486 mentioned this pull request Aug 17, 2023
Closed
dibarbet
dibarbet approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@dibarbet dibarbet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Thanks for the contribution!

@dibarbet
Copy link
Member

dibarbet commented Aug 17, 2023 •
edited
Loading

Are you able to sign the license/cla check or is it bugged?

@dandev486
Copy link
Contributor Author

@dibarbet, not sure on how to answer, how can I check if it is bugged?

@dibarbet
Copy link
Member

I guess it should have posted a link to an agree button... let me try opening / closing.

@dibarbet dibarbet closed this Aug 17, 2023
@dibarbet dibarbet reopened this Aug 17, 2023
@dandev486
Copy link
Contributor Author

Still no message from my perspective, I'll try to close this one and open another pull request to check if the message appears.

@dandev486 dandev486 closed this Aug 17, 2023
@dandev486 dandev486 mentioned this pull request Aug 17, 2023
Merged
@dandev486 dandev486 deleted the updates-dotnet-path-configuration-description branch August 18, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibarbet dibarbet dibarbet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dandev486 @dibarbet