IDE0036 errors when building with Preview 6 SDK

[NikolaMilosavljevic]

When building with .NET 9 Preview 6 SDK (i.e. 9.0.100-preview.6.24303.27), there are 3 IDE0036 errors:

    D:\a\_work\1\vmr\src\winforms\src\System.Drawing.Common\src\System\Drawing\ImageConverter.cs(42,5): error IDE0036: Modifiers are not ordered (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0036) [D:\a\_work\1\vmr\src\winforms\src\System.Drawing.Common\src\System.Drawing.Common.csproj::TargetFramework=net8.0]
    D:\a\_work\1\vmr\src\winforms\src\System.Drawing.Common\src\System\Drawing\ImageConverter.cs(42,5): error IDE0036: Modifiers are not ordered (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0036) [D:\a\_work\1\vmr\src\winforms\src\System.Drawing.Common\src\System.Drawing.Common.csproj::TargetFramework=net9.0]
    D:\a\_work\1\vmr\src\winforms\src\System.Drawing.Common\src\System\Drawing\Imaging\Effects\Effect.cs(11,1): error IDE0036: Modifiers are not ordered (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0036) [D:\a\_work\1\vmr\src\winforms\src\System.Drawing.Common\src\System.Drawing.Common.csproj::TargetFramework=net9.0]

From: dotnet/sdk#41417 (comment)

[elachlan]

We have it set to a warning in the CodeAnalysis globalconfig. Maybe it isn't getting applied to System.Drawing.Common?

winforms/eng/CodeAnalysis.src.globalconfig

Lines 1541 to 1542 in aa61778

	# IDE0036: Order modifiers
	dotnet_diagnostic.IDE0036.severity = warning

[NikolaMilosavljevic]

Source-build and unified-build use /p:TreatWarningsAsErrors=true so all warnings will become errors.

There are more errors, of the same type: dotnet/sdk#41417 (comment)

[elachlan]

We have TreatWarningsAsErrors=true in our CI builds. I also locally set the analyzer to error instead of warning and didn't get any hits. Its like the analyzer isn't getting run.

[elachlan]

@sharwell IDE0036 seems to not be working here, could you point us in the right direction?

[akoeplinger]

Maybe caused by dotnet/roslyn#73339? i.e. it was silently ignored before that fix

[ViktorHofer]

Any update on this? We still have a patch for it in the VMR: https://github.com/dotnet/sdk/blob/main/src/SourceBuild/patches/winforms/0001-Suppress-IDE0036-errors.patch

[elachlan]

@ViktorHofer we think it's a Roslyn bug? The analyzer isn't firing for us.

[akoeplinger]

@elachlan I hacked the System.Drawing.Common build so it still built with the 8.0.100 SDK and it does show the same analyzer errors there so I'm almost certain that it was just silently ignored on 8.0.200+ until the fix in dotnet/roslyn#73339

So these look like genuine findings. You can bump the SDK version to e.g. 9.0.100-preview.6.24303.27 in global.json locally and run build.cmd, it will show the errors.

[akoeplinger]

Opened a PR: #11571

[alandryz83]

Sent from my iPhoneOn Jun 5, 2024, at 11:51 PM, Lachlan Ennis ***@***.***> wrote: We have TreatWarningsAsErrors=true in our CI builds. I also locally set the analyzer to error instead of warning and didn't get any hits. Its like the analyzer isn't getting run. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>