Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable IDE0074 Use compound assignment #7921

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Enable IDE0074 Use compound assignment #7921

merged 1 commit into from
Oct 13, 2022

Conversation

elachlan
Copy link
Contributor

@elachlan elachlan commented Oct 11, 2022 •
edited by ghost
Loading

Enables IDE0074 Use compound assignment

Related #7887

Microsoft Reviewers: Open in CodeFlow

@elachlan elachlan requested a review from a team as a code owner October 11, 2022 07:24
@ghost ghost assigned elachlan Oct 11, 2022
@dreddy-work
Copy link
Member

@elachlan build failures in release.
src\System.Windows.Forms.Design\src\System\ComponentModel\Design\ReferenceService.cs#L375
src\System.Windows.Forms.Design\src\System\ComponentModel\Design\ReferenceService.cs(375,25): error IDE0074: (NETCORE_ENGINEERING_TELEMETRY=Build) Use compound assignment

@elachlan elachlan force-pushed the IDE0074 branch 2 times, most recently from aa7b797 to d2cb990 Compare October 11, 2022 21:57
@elachlan
Copy link
Contributor Author

@elachlan build failures in release. src\System.Windows.Forms.Design\src\System\ComponentModel\Design\ReferenceService.cs#L375 src\System.Windows.Forms.Design\src\System\ComponentModel\Design\ReferenceService.cs(375,25): error IDE0074: (NETCORE_ENGINEERING_TELEMETRY=Build) Use compound assignment

Refactored it a bit around that property since it had too many if statements.

@runfoapp runfoapp bot mentioned this pull request Oct 11, 2022
Closed
@RussKie
Copy link
Member

RussKie commented Oct 11, 2022

MC

@RussKie RussKie added the waiting-author-feedback The team requires more information from the author label Oct 11, 2022
RussKie
RussKie previously approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Oct 12, 2022
@elachlan
Copy link
Contributor Author

@RussKie I think this is another flaky test.

@RussKie RussKie enabled auto-merge (squash) October 12, 2022 06:16
@RussKie RussKie added enhancement Product code improvement that does NOT require public API changes/additions code cleanup cleanup code for unused apis/properties/comments - no functional changes. labels Oct 12, 2022
@RussKie RussKie merged commit bc73fc2 into dotnet:main Oct 13, 2022
@ghost ghost added this to the 8.0 Preview1 milestone Oct 13, 2022
@elachlan elachlan deleted the IDE0074 branch October 13, 2022 20:30
v-elnovikova pushed a commit to v-elnovikova/winforms that referenced this pull request Oct 18, 2022
@elachlan @v-elnovikova
Enable IDE0074 Use compound assignment (dotnet#7921)
954bf63
@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dreddy-work dreddy-work dreddy-work approved these changes

@RussKie RussKie RussKie left review comments

Assignees

@elachlan elachlan

Labels
code cleanup cleanup code for unused apis/properties/comments - no functional changes. enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
8.0 Preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@elachlan @dreddy-work @RussKie