Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added vignettes for theoph and sd-iv_pkpd #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vjd
Copy link

@vjd vjd commented May 4, 2017

Hey. can you check out the format of the vignettes for the datasets in here. Just wondering if this sort of information is useful for the datasets package?

Copy link
Owner

@dpastoor dpastoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I really like the idea. The couple things that will need to be changed:

  • add DiagrammeR to suggests
  • add a head() of the dataset

Perhaps also some very light exploratory visualization regarding the time-course and or demographics (at least for sd_iv

---

```{r echo=FALSE}
library(DiagrammeR)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to add DiagrammeR to Suggests so the vignette can be knit. Really like the idea

date: "`r Sys.Date()`"
output: rmarkdown::html_vignette
vignette: >
%\VignetteIndexEntry{Single Dose IV - PKPD}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to keep the vignette name as simple as possible since they'll have to type it exactly in vignette(...) maybe tie it directly to the dataset (I presume this is for sd_iv_rich_pkpd?

@dpastoor
Copy link
Owner

dpastoor commented May 4, 2017

pushed some documentation tweaks so will build vignettes into documentation now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants