-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added vignettes for theoph and sd-iv_pkpd #3
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I really like the idea. The couple things that will need to be changed:
- add DiagrammeR to suggests
- add a
head()
of the dataset
Perhaps also some very light exploratory visualization regarding the time-course and or demographics (at least for sd_iv
--- | ||
|
||
```{r echo=FALSE} | ||
library(DiagrammeR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll need to add DiagrammeR to Suggests so the vignette can be knit. Really like the idea
date: "`r Sys.Date()`" | ||
output: rmarkdown::html_vignette | ||
vignette: > | ||
%\VignetteIndexEntry{Single Dose IV - PKPD} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to keep the vignette name as simple as possible since they'll have to type it exactly in vignette(...)
maybe tie it directly to the dataset (I presume this is for sd_iv_rich_pkpd
?
pushed some documentation tweaks so will build vignettes into documentation now |
Hey. can you check out the format of the vignettes for the datasets in here. Just wondering if this sort of information is useful for the datasets package?