Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] support external blob #1545

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Feb 2, 2024

Related PR: containerd/nydus-snapshotter#580

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@imeoer imeoer force-pushed the external-blob branch 3 times, most recently from d099826 to bb6ff6e Compare February 2, 2024 09:52
@imeoer imeoer marked this pull request as ready for review February 2, 2024 09:53
@imeoer imeoer requested a review from a team as a code owner February 2, 2024 09:53
@imeoer imeoer requested review from bergwolf, power-more and Desiki-high and removed request for a team February 2, 2024 09:53
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: Patch coverage is 41.47627% with 333 lines in your changes missing coverage. Please review.

Project coverage is 60.22%. Comparing base (dd9ba54) to head (f914b91).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
builder/src/directory.rs 0.00% 84 Missing ⚠️
storage/src/backend/external/meta.rs 0.00% 40 Missing ⚠️
storage/src/backend/external/mod.rs 10.00% 36 Missing ⚠️
src/bin/nydus-image/main.rs 0.00% 35 Missing ⚠️
builder/src/core/context.rs 61.53% 18 Missing and 7 partials ⚠️
storage/src/backend/external/local.rs 0.00% 22 Missing ⚠️
builder/src/attributes.rs 75.67% 14 Missing and 4 partials ⚠️
storage/src/cache/fscache/mod.rs 33.33% 15 Missing and 1 partial ⚠️
storage/src/cache/filecache/mod.rs 31.81% 15 Missing ⚠️
builder/src/core/node.rs 57.69% 8 Missing and 3 partials ⚠️
... and 10 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1545      +/-   ##
==========================================
- Coverage   60.42%   60.22%   -0.21%     
==========================================
  Files         146      150       +4     
  Lines       48943    49398     +455     
  Branches    46380    46835     +455     
==========================================
+ Hits        29573    29748     +175     
- Misses      17906    18174     +268     
- Partials     1464     1476      +12     
Files with missing lines Coverage Δ
api/src/config.rs 88.78% <100.00%> (+0.03%) ⬆️
builder/src/core/bootstrap.rs 77.63% <100.00%> (+0.29%) ⬆️
builder/src/core/chunk_dict.rs 70.18% <ø> (ø)
builder/src/lib.rs 64.25% <ø> (ø)
builder/src/merge.rs 70.73% <100.00%> (ø)
builder/src/stargz.rs 75.00% <100.00%> (+0.14%) ⬆️
builder/src/tarball.rs 63.26% <100.00%> (+0.57%) ⬆️
storage/src/backend/mod.rs 56.19% <ø> (ø)
storage/src/device.rs 67.83% <100.00%> (+0.10%) ⬆️
storage/src/meta/chunk_info_v1.rs 97.11% <100.00%> (ø)
... and 21 more

... and 2 files with indirect coverage changes

@imeoer imeoer force-pushed the external-blob branch 8 times, most recently from 80ad7d8 to 5ad8112 Compare February 8, 2024 09:54
@imeoer imeoer mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant