Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(formula): defined name cache for getValueByName #4675

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

Dushusir
Copy link
Member

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Feb 19, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Feb 19, 2025

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 34 seconds
commit  30578c4
info  For more information, see full report

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 46.66667% with 16 lines in your changes missing coverage. Please review.

Project coverage is 32.67%. Comparing base (4b38dc6) to head (30578c4).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...gine-formula/src/services/defined-names.service.ts 46.66% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4675      +/-   ##
==========================================
+ Coverage   32.65%   32.67%   +0.01%     
==========================================
  Files        2605     2605              
  Lines      135611   135635      +24     
  Branches    30182    30188       +6     
==========================================
+ Hits        44286    44317      +31     
+ Misses      91325    91318       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir force-pushed the dushusir/formula-bugs0219 branch from 53c0837 to 30578c4 Compare February 20, 2025 06:13
@Dushusir Dushusir merged commit 1f6bcd7 into dev Feb 20, 2025
9 checks passed
@Dushusir Dushusir deleted the dushusir/formula-bugs0219 branch February 20, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants