Pass down schema on table creation #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpannek
force-pushed
the
apply-schema-to-tables
branch
3 times, most recently
from
61d9820 to
82a7bbf
Compare
simonpannek
force-pushed
the
apply-schema-to-tables
branch
from
82a7bbf to
442df41
Compare
|
The test cases around this don't seem to have that great coverage. I added two basic cases, but we might want to do some manual testing/extend these before merging. |
bcmeireles
reviewed
Feb 19, 2025
| kwargs = { | ||
| "database": relation_parts[0], | ||
| "schema": relation_parts[1], | ||
| "identifier": relation_parts[2], | ||
| "schema": ".".join(relation_parts[1:-1]), |
There was a problem hiding this comment.
What if there is no 1st element? and only zero one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
There is no out-of-the-box way to configure dbt models materialised as tables to be created in subdirectories.
Test Results
Added tests to check the new behavior.
Changelog
Contributor License Agreement