Skip to content

Commit

Permalink
sdk: fix DLOB.updateOrder (#290)
Browse files Browse the repository at this point in the history
* Fix for "readonly" bug when DLOB tries to update nodelist with new events

* fix test

* have updateOrder match other update order implementations

* update CHANGELOG

Co-authored-by: Chris Heaney <[email protected]>
  • Loading branch information
lukecaan and crispheaney authored Dec 13, 2022
1 parent b3665c0 commit db89fda
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixes

- ts-sdk: fix DLOB.updateOrder ([#290](https://github.com/drift-labs/protocol-v2/pull/290))
- ts-sdk: make calculateClaimablePnl mirror on-chain logic ([#291](https://github.com/drift-labs/protocol-v2/pull/291))
- ts-sdk: add margin trading toggle field to user accounts, update toggle margin trading function to add ability to toggle for any subaccount rather than just the active ([#285](https://github.com/drift-labs/protocol-v2/pull/285))

Expand Down
8 changes: 6 additions & 2 deletions sdk/src/dlob/DLOB.ts
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,12 @@ export class DLOB {
return;
}

order.baseAssetAmountFilled = cumulativeBaseAssetAmountFilled;
this.getListForOrder(order)?.update(order, userAccount);
const newOrder = {
...order,
};
newOrder.baseAssetAmountFilled = cumulativeBaseAssetAmountFilled;

this.getListForOrder(order)?.update(newOrder, userAccount);

if (onUpdate) {
onUpdate();
Expand Down

0 comments on commit db89fda

Please sign in to comment.