Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "readonly" bug when DLOB tries to update nodelist with new ev… #290

Merged
merged 5 commits into from
Dec 13, 2022
Merged

Fix for "readonly" bug when DLOB tries to update nodelist with new ev… #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba015d7
Fix for "readonly" bug when DLOB tries to update nodelist with new ev…
lukecaan Dec 13, 2022
0458c96
fix test
crispheaney Dec 13, 2022
9139aa8
have updateOrder match other update order implementations
crispheaney Dec 13, 2022
bff255e
Merge branch 'master' into luke/dpe-898-dlob-update-bug
crispheaney Dec 13, 2022
6f2fa3c
update CHANGELOG
crispheaney Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixes

- ts-sdk: fix DLOB.updateOrder ([#290](https://github.com/drift-labs/protocol-v2/pull/290))
- ts-sdk: make calculateClaimablePnl mirror on-chain logic ([#291](https://github.com/drift-labs/protocol-v2/pull/291))
- ts-sdk: add margin trading toggle field to user accounts, update toggle margin trading function to add ability to toggle for any subaccount rather than just the active ([#285](https://github.com/drift-labs/protocol-v2/pull/285))

Expand Down
8 changes: 6 additions & 2 deletions sdk/src/dlob/DLOB.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,12 @@ export class DLOB {
return;
}

order.baseAssetAmountFilled = cumulativeBaseAssetAmountFilled;
this.getListForOrder(order)?.update(order, userAccount);
const newOrder = {
...order,
};
newOrder.baseAssetAmountFilled = cumulativeBaseAssetAmountFilled;

this.getListForOrder(order)?.update(newOrder, userAccount);

if (onUpdate) {
onUpdate();
Expand Down