Fix namespace for asm! macro #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the feature attribute asm and add a namespace for
the usage of the asm macro.
Currently the following build error is generated when using
rustc 1.66.0-nightly (c0983a9aa 2022-10-12):
$ cargo b
Compiling drogue-boot v0.1.2 (/iot/drogue/drogue-boot)
error: cannot find macro `asm` in this scope
--> src/lib.rs:100:9
|
100 | asm! {
| ^^^
|
= note: consider importing this macro:
core::arch::asm
warning: the feature `asm` has been stable since 1.59.0 and no longer
requires an attribute to enable
--> src/lib.rs:4:12
|
4 | #![feature(asm)]
| ^^^
|
= note: `#[warn(stable_features)]` on by default
warning: `drogue-boot` (lib) generated 1 warning
error: could not compile `drogue-boot` due to previous error; 1 warning emitted
Refs: rust-lang/rust#84019
Signed-off-by: Daniel Bevenius <[email protected]>
|
Sorry about this, I was supposed to look at embassy-boot and not this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the feature attribute asm and add a namespace for the usage of the asm macro.
Currently the following build error is generated when using rustc 1.66.0-nightly (c0983a9aa 2022-10-12):
Refs: rust-lang/rust#84019
Signed-off-by: Daniel Bevenius [email protected]