-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebConfigPropertyCollection: Allow deleting single item property collections, update examples, remove duplicate resource documentation #644
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
===================================
Coverage 88% 88%
===================================
Files 15 15
Lines 1952 1954 +2
===================================
+ Hits 1726 1728 +2
Misses 226 226
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 6 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Borgquite)
One thing I've just thought about @Borgquite, can you add a link in the README to the Wiki. e.g. 'The resource examples are also available in the WebAdministrationDsc Wiki.' |
@dan-hughes Already there? WebAdministrationDsc/README.md Line 42 in c3efe11
|
So it is. I went to the bottom, saw the examples and didn't look very hard after that! Could do with cleaning up the two examples headings. Beat me to it! Should be good now. |
@dan-hughes Ah, I see what's happened - there are two Examples sections in the README file, one with, one without. I've just merged them |
Pull Request (PR) description
Add support for single item property value collections - add is already supported with the correct syntax, so have updated examples & added 'delete' support.
(NB 'Updating' a single item property value collection is pretty meaningless as there's nothing relevant to 'update' - you can only add or delete).
Also removing the duplicated resource documentation under README.md. Most resources solely rely on the Wiki, which should surely be the 'single source of truth' for resource documentation now, like for other modules?
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).
help.
This change is