Support profile params in run configurations #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r4victor
force-pushed
the
issue_943_include_profiles_in_configurations
branch
from
babe7cc to
c0fc0eb
Compare
Bihan
pushed a commit
to SMTM-Capital/dstack
that referenced
this pull request
Apr 30, 2024
* Include profile parameters in run configurations * Use merged_profile * Fix tests * Fix fields descriptions * Minor fixes * Fix typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #943.
This PR allows users to specify profile parameter in run configurations directly, for example:
The profile parameters are merged in the following priority:
dstack runargumentsTODO: the refactoring of
Requirements/Profile/JobSpecto address the issues mentioned in #943 is to be done in a separate PR. The refactoring PR may require breaking backward compatibility. This PR is backward-compatible.