Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pool-related CLI arguments respect profile #954

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

r4victor
Copy link
Collaborator

@r4victor r4victor commented Mar 1, 2024

Closes #949

  • Make dstack run respect pool-related profiles.yml settings.
  • Refactor dstack run and dstack pool add to share profiles.yml CLI arguments.
  • Remove redundant CLI arguments/parsing and reuse profiles.yml validation.
  • Remove dstack run-specific arguments from dstack pool add, e.g. --max-duration.
  • Extend run plan table with pool-related policies.

@r4victor r4victor merged commit 38115c8 into master Mar 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: dstack run does not respect pool-related profiles.yml parameters
1 participant