added 4 tokens : OLAS, sDAI, stETH and EURe - on gnosis chain #5794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Workflow run id 8751643485 approved. |
|
Workflow run id 8751643704 approved. |
|
Workflow run id 8751643700 approved. |
Hosuke
requested changes
Apr 19, 2024
| ('sdai-savings-dai', 'gnosis', 'SDAI',0xaf204776c7245bF4147c2612BF6e5972Ee483701,18), | ||
| ('eure-monerium-eur-emoney', 'gnosis', 'EURe', 0xcB444e90D8198415266c6a2724b7900fb12FC56E, 18), | ||
| ('olas-autonolas', 'gnosis', 'OLAS', 0xcE11e14225575945b8E6Dc0D4F2dD4C570f79d9f, 18), | ||
| ('steth-lido-staked-ether-on-xDAI', 'gnosis', 'stETH', 0xae7ab96520de3a18e5e111b5eaab095312d7fe84, 18) |
There was a problem hiding this comment.
Hi @PoloX2021,
Do you think steth-lido-staked-ether works here? As steth-lido-staked-ether-on-xDAI is not a legal token-id.
Also please check the address in this line.
Suggested change
| ('steth-lido-staked-ether-on-xDAI', 'gnosis', 'stETH', 0xae7ab96520de3a18e5e111b5eaab095312d7fe84, 18) | |
| ('steth-lido-staked-ether', 'gnosis', 'stETH', 0x3c037849a8ffcf19886e2f5b04f293b7847d0377, 18) |
There was a problem hiding this comment.
It's done I changed the name to what you suggested. i also noticed that the address was the one for ethereum so I changed it to the one for gnosis. (I also double checked all the other ones ;) )
|
Workflow run id 8756219621 approved. |
Hosuke
approved these changes
Apr 20, 2024
Hosuke
added
easy
ready-for-merging
and removed
in review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 4 tokens to gnosis_chain