-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prices_native_tokens.sql #5803
Conversation
Add ROSE, SAGA, KAS, EGLD, NTRN, FLR, and AR
Workflow run id 8774029591 approved. |
Workflow run id 8774029651 approved. |
Hi @Hosuke , need help here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.✅ for the syntax,
thank you @lydiapuspita
('manta-manta-network', null, 'MANTA', null, null), | ||
('rose-oasis-network', null, 'ROSE', null, null), | ||
('saga-saga', null, 'SAGA', null, null), | ||
('kas-kaspa', null, 'KAS', null, null), | ||
('egld-elrond', null, 'EGLD', null, null), | ||
('ntrn1-neutron', null, 'NTRN', null, null), | ||
('flr-flare-network', null, 'FLR', null, null), | ||
('ar-arweave', null, 'AR', null, null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not fully sure which chains are these tokens natively from though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we're safe to add, as long as passing tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, it's all good?
should I update the branch?
because of this warning --> "This branch is out-of-date with the base branch"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nah, you're good, merging now
Add ROSE, SAGA, KAS, EGLD, NTRN, FLR, and AR
Thank you for contributing to Spellbook!
Thank you for taking the time to submit code in Spellbook. A few things to consider:
Best practices
To speed up your development process in PRs, keep these tips in mind:
readme
) and rundbt compile
target/
directory to copy/paste and run on Dune directly for initial query testingWHERE
filter for only ~7 days of history on large source tables, i.e.ethereum.transactions
Incremental model setup
COALESCE()
as needed on key column(s), otherwise the tests may fail on duplicates🪄 Use the built CI tables for testing 🪄
Once CI completes, you can query the CI tables and errors in dune when it finishes running.
run initial models
andtest initial models
, there will be a schema that looks like this:test_schema.git_dunesql_4da8bae_sudoswap_v2_base_pool_creations
Leverage these tables to perform QA testing on Dune query editor -- or even full test dashboards!
Spellbook contribution docs
The docs directory has been implemented to answer as many questions as possible. Please take the time to reference each
.md
file within this directory to understand how to efficiently contribute & why the repo is designed as it is 🪄Example questions to be answered:
Please navigate through the docs directory to find as much info as you can.
Note: happy to take PRs to improve the docs, let us know 🤝