Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add solgun bot trades spellbook #5805

Merged

Conversation

whalehunting
Copy link
Contributor

@whalehunting whalehunting commented Apr 21, 2024

Added spellbook for solgun bot trades using the new filestructure by @Hosuke
giving me some weird error though, hope someone can tell me what i need to fix 😆

@dune-eng
Copy link

Workflow run id 8774841360 approved.

@dune-eng
Copy link

Workflow run id 8774841437 approved.

@Hosuke
Copy link
Collaborator

Hosuke commented Apr 22, 2024

Added spellbook for solgun bot trades using the new filestructure by @Hosuke giving me some weird error though, hope someone can tell me what i need to fix 😆

Tests passed now.

@dune-eng
Copy link

Workflow run id 8788532192 approved.

@dune-eng
Copy link

Workflow run id 8788532160 approved.

@whalehunting
Copy link
Contributor Author

Added spellbook for solgun bot trades using the new filestructure by @Hosuke giving me some weird error though, hope someone can tell me what i need to fix 😆

Tests passed now.

great! is there anything left for me to do to get this merged?

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ser, thank you

@jeff-dude
Copy link
Member

i'll plan to do some merges tomorrow

@jeff-dude jeff-dude merged commit b8c8112 into duneanalytics:main Apr 23, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants