Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zkevm to dex_base_trades.sql #5819

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

chef-seaweed
Copy link
Contributor

@chef-seaweed chef-seaweed commented Apr 24, 2024

This a follow-up PR for

          just realized this won't make it to `dex.trades`, as it's a new chain and needs added to `dex_base_trades.sql`

@chef-seaweed or @Hosuke feel free to add whenever in a follow-up PR 👍

Originally posted by @jeff-dude in #5815 (comment)

@dune-eng
Copy link

Workflow run id 8810401558 approved.

@dune-eng
Copy link

Workflow run id 8810401937 approved.

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chef-seaweed

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@jeff-dude jeff-dude self-assigned this Apr 24, 2024
@jeff-dude jeff-dude merged commit a7d4ec4 into duneanalytics:main Apr 24, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants