Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding m-btc and solvBTC prices in prices_linea_tokens.sql #6237

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

0xroll
Copy link
Contributor

@0xroll 0xroll commented Jun 22, 2024

adding m-btc and solvBTC on linea

Thank you for contributing to Spellbook 🪄

Contribution type

Please check the type of contribution this pull request is for:

  • Adding to existing spell lineage

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [adding m-btc and solvbtc in prices table]

Additional information

Please provide any additional information that might help us review your pull request:

https://api.coinpaprika.com/v1/coins/m-btc-merlins-seal-btc
https://api.coinpaprika.com/v1/coins/solvbtc-solv-protocol-solvbtc


adding m-btc and solvBTC on linea
@dune-eng
Copy link

Workflow run id 9623628911 approved.

@dune-eng
Copy link

Workflow run id 9623629181 approved.

@dune-eng
Copy link

Workflow run id 9623629198 approved.

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @0xroll

@@ -26,7 +26,8 @@ def __init__(self):
"zksync": "zksync-zksync",
"zora": "eth-ethereum",
"mantle": "mnt-mantle",
"blast": "blast-blast"
"blast": "blast-blast",
"linea": "eth-ethereum"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding linea support similar to zora.

(Currently linea and zora are still not in the coinpaprika list: https://api.coinpaprika.com/v1/contracts/)

@@ -24,4 +24,6 @@ FROM
,('uni-uniswap', 'linea', 'UNI', 0x636B22bC471c955A8DB60f28D4795066a8201fa3, 18)
,('link-chainlink', 'linea', 'LINK', 0x5B16228B94b68C7cE33AF2ACc5663eBdE4dCFA2d, 18)
,('dai-dai', 'linea', 'DAI', 0x4AF15ec2A0BD43Db75dd04E62FAA3B8EF36b00d5, 18)
,('m-btc-merlins-seal-btc', 'linea', 'M-BTC',0xe4D584ae9b753e549cAE66200A6475d2f00705f7, 18)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -24,4 +24,6 @@ FROM
,('uni-uniswap', 'linea', 'UNI', 0x636B22bC471c955A8DB60f28D4795066a8201fa3, 18)
,('link-chainlink', 'linea', 'LINK', 0x5B16228B94b68C7cE33AF2ACc5663eBdE4dCFA2d, 18)
,('dai-dai', 'linea', 'DAI', 0x4AF15ec2A0BD43Db75dd04E62FAA3B8EF36b00d5, 18)
,('m-btc-merlins-seal-btc', 'linea', 'M-BTC',0xe4D584ae9b753e549cAE66200A6475d2f00705f7, 18)
,('solvbtc-solv-protocol-solvbtc', 'linea', 'solvBTC', 0x5FFcE65A40f6d3de5332766ffF6A28BF491C868c, 18)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeff-dude jeff-dude self-assigned this Jun 26, 2024
@jeff-dude jeff-dude merged commit e228059 into duneanalytics:main Jun 26, 2024
4 checks passed
Copy link

gitpoap-bot bot commented Jun 26, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Dune Contributor:

GitPOAP: 2024 Dune Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants