-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZeroEx - Settler revert-revert #6485
Conversation
Update socialtokens.sql
dbt_subprojects/dex/models/aggregator_trades/dex_aggregator_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/models/aggregator_trades/dex_aggregator_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/models/_projects/zeroex/zeroex_api_fills_deduped.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/models/_projects/zeroex/zeroex_api_fills_deduped.sql
Outdated
Show resolved
Hide resolved
@jeff-dude this reverts the previous revert #6462 additional changes (commented above) added for successful dex_agg run |
thank you, will review asap |
Workflow run id 10204737026 approved. |
Workflow run id 10204737404 approved. |
Workflow run id 10204745983 approved. |
Workflow run id 10204746245 approved. |
Workflow run id 10207078165 approved. |
Workflow run id 10207078098 approved. |
, token_bought_amount_raw | ||
, token_sold_amount_raw | ||
, try_cast(token_bought_amount_raw as uint256) as token_bought_amount_raw | ||
, try_cast(token_sold_amount_raw as uint256) as token_sold_amount_raw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all set with casting as uint256
@jeff-dude
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, i am checking with other teams where this data is coming from to be safe. this is a good safeguard plan if we don't have any definitive answers to solve at project level spells
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i also noticed another dune teammate request this, looks like same request but on dex.trades
. that one uses cast
, but we could convert to try_cast
there too
Workflow run id 10207967793 approved. |
Workflow run id 10207968163 approved. |
all looks good outside that above comment 🙏 |
Thank you for contributing to Spellbook 🪄
Update!
Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.
Contribution type
Please check the type of contribution this pull request is for:
Note: You can safely discard any section below which doesn't apply based on selection above
For new spell(s)
If you are building new spell(s), please provide the following information:
For adding to existing spell lineage
If you are adding to an existing spell lineage, please provide the following information:
For bug fixes
If you are fixing a bug, please provide the following information:
Additional information
Please provide any additional information that might help us review your pull request:
Thank you for your contribution!