Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZeroEx - Settler revert-revert #6485

Merged
merged 98 commits into from
Aug 5, 2024
Merged

Conversation

RantumBits
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Update!

Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): schema.table_name
  • Description: [Detailed description of the new spell(s) and their purpose]
  • Who are the new spell(s) for? [Internal team or general community]
  • How will the new spell(s) be used downstream? [Description of downstream usage]
  • Implementation details: [Information on how the spell(s) are implemented]
  • Test instructions: [How to test the new spell(s)]
  • Related issue(s): [Link to related issues, if any]

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]

For bug fixes

If you are fixing a bug, please provide the following information:

  • Description: [Description of the bug fix]
  • Steps to reproduce: [How to reproduce the bug]
  • Implementation details: [Information on how the bug was fixed]
  • Test instructions: [How to test the fix]
  • Related issue(s): [Link to related issues, if any]

Additional information

Please provide any additional information that might help us review your pull request:

  • [Any additional information]

Thank you for your contribution!

RantumBits and others added 30 commits June 1, 2021 14:07
@RantumBits
Copy link
Contributor Author

@jeff-dude this reverts the previous revert #6462

additional changes (commented above) added for successful dex_agg run

@jeff-dude
Copy link
Member

@jeff-dude this reverts the previous revert #6462

additional changes (commented above) added for successful dex_agg run

thank you, will review asap

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10204737026 approved.

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10204737404 approved.

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10204745983 approved.

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10204746245 approved.

@RantumBits RantumBits marked this pull request as ready for review August 1, 2024 20:12
@jeff-dude jeff-dude self-assigned this Aug 1, 2024
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR dbt: dex covers the DEX dbt subproject labels Aug 1, 2024
@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10207078165 approved.

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10207078098 approved.

, token_bought_amount_raw
, token_sold_amount_raw
, try_cast(token_bought_amount_raw as uint256) as token_bought_amount_raw
, try_cast(token_sold_amount_raw as uint256) as token_sold_amount_raw
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all set with casting as uint256 @jeff-dude

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, i am checking with other teams where this data is coming from to be safe. this is a good safeguard plan if we don't have any definitive answers to solve at project level spells

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i also noticed another dune teammate request this, looks like same request but on dex.trades. that one uses cast, but we could convert to try_cast there too

@dune-eng
Copy link

dune-eng commented Aug 2, 2024

Workflow run id 10207967793 approved.

@dune-eng
Copy link

dune-eng commented Aug 2, 2024

Workflow run id 10207968163 approved.

@jeff-dude jeff-dude added ready-for-final-review and removed in review Assignee is currently reviewing the PR labels Aug 2, 2024
@jeff-dude
Copy link
Member

all looks good outside that above comment 🙏

@jeff-dude jeff-dude merged commit cf6c42b into duneanalytics:main Aug 5, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants