Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zeroex settler - revise model [base] #6659

Merged
merged 19 commits into from
Sep 18, 2024
Merged

zeroex settler - revise model [base] #6659

merged 19 commits into from
Sep 18, 2024

Conversation

RantumBits
Copy link
Contributor

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above

For bug fixes

If you are fixing a bug, please provide the following information:

  • Description: [Description of the bug fix]
  • fix maker token values
  • Steps to reproduce: [How to reproduce the bug]
  • Implementation details: [Information on how the bug was fixed]
  • Test instructions: [How to test the fix]
  • Related issue(s): [Link to related issues, if any]
    zeroex - update maker token value selection #6658

@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10689727298 approved.

@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10689727331 approved.

@RantumBits RantumBits changed the title update maker token value selection zeroex - update maker token value selection [base] Sep 3, 2024
@RantumBits RantumBits marked this pull request as ready for review September 3, 2024 22:09
@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10691391641 approved.

@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10691391720 approved.

@RantumBits RantumBits changed the title zeroex - update maker token value selection [base] [draft] zeroex - update maker token value selection [base] Sep 3, 2024
@RantumBits
Copy link
Contributor Author

[draft] - marked 'ready for review' by mistake. timed out on first test run

jeff-dude
jeff-dude approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

triggered CI to rerun, will wait to see. likely timed out due to running at same time as other PR.

@jeff-dude jeff-dude self-assigned this Sep 4, 2024
@jeff-dude
Copy link
Member

hmm def concerning that this one chain is running so long, while the other PR with multiple chains ran in 20 minutes. was this an issue on initial build? is there a bug in the query?

@dune-eng
Copy link

dune-eng commented Sep 4, 2024

Workflow run id 10709774819 approved.

@dune-eng
Copy link

dune-eng commented Sep 4, 2024

Workflow run id 10709774966 approved.

@dune-eng
Copy link

dune-eng commented Sep 4, 2024

Workflow run id 10709875918 approved.

@dune-eng
Copy link

dune-eng commented Sep 4, 2024

Workflow run id 10709875919 approved.

@dune-eng
Copy link

dune-eng commented Sep 4, 2024

Workflow run id 10709922173 approved.

@dune-eng
Copy link

dune-eng commented Sep 4, 2024

Workflow run id 10709922322 approved.

@dune-eng
Copy link

dune-eng commented Sep 5, 2024

Workflow run id 10729762562 approved.

@dune-eng
Copy link

dune-eng commented Sep 5, 2024

Workflow run id 10729762711 approved.

@dune-eng
Copy link

dune-eng commented Sep 5, 2024

Workflow run id 10729819500 approved.

@dune-eng
Copy link

dune-eng commented Sep 5, 2024

Workflow run id 10729819780 approved.

@dune-eng
Copy link

Workflow run id 10893669349 approved.

@dune-eng
Copy link

Workflow run id 10893669571 approved.

@dune-eng
Copy link

Workflow run id 10893671163 approved.

@dune-eng
Copy link

Workflow run id 10893671277 approved.

@dune-eng
Copy link

Workflow run id 10893707185 approved.

@dune-eng
Copy link

Workflow run id 10893707297 approved.

@jeff-dude jeff-dude added WIP work in progress and removed ready-for-merging blocked labels Sep 17, 2024
@dune-eng
Copy link

Workflow run id 10909648558 approved.

@dune-eng
Copy link

Workflow run id 10909648471 approved.

@dune-eng
Copy link

Workflow run id 10909691231 approved.

@dune-eng
Copy link

Workflow run id 10909691538 approved.

@dune-eng
Copy link

Workflow run id 10912948128 approved.

@dune-eng
Copy link

Workflow run id 10912948382 approved.

@RantumBits
Copy link
Contributor Author

this is now ready @jeff-dude

@RantumBits RantumBits changed the title [draft] zeroex settler - revise model [base] zeroex settler - revise model [base] Sep 18, 2024
jeff-dude
jeff-dude approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run time looks much better, thank you!

@jeff-dude jeff-dude added ready-for-merging and removed WIP work in progress labels Sep 18, 2024
@jeff-dude jeff-dude merged commit 18a46bd into duneanalytics:main Sep 18, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
@RantumBits RantumBits deleted the maker_values_b branch September 18, 2024 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeff-dude jeff-dude jeff-dude approved these changes

Assignees

@jeff-dude jeff-dude

Labels
ready-for-merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RantumBits @dune-eng @jeff-dude