Remove unnecessary logs and add Ender metrics

dydxprotocol · Aug 21, 2024 · 2aef590 · 2aef590
1 parent ba3492b
commit 2aef590
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 15 deletions.
diff --git a/indexer/packages/kafka/src/batch-kafka-producer.ts b/indexer/packages/kafka/src/batch-kafka-producer.ts
@@ -1,8 +1,9 @@
-import { logger } from '@dydxprotocol-indexer/base';
+import { logger, stats } from '@dydxprotocol-indexer/base';
 import { IHeaders, Producer, RecordMetadata } from 'kafkajs';
 import _ from 'lodash';
 
 import { KafkaTopics } from './types';
+import config from './config';
 
 /**
  * Single message sent to the producer.
@@ -65,6 +66,7 @@ export class BatchKafkaProducer {
   }
 
   private sendBatch(): void {
+    const startTime: number = Date.now();
     if (!_.isEmpty(this.producerMessages)) {
       this.producerPromises.push(
         this.producer.send({ topic: this.topic, messages: this.producerMessages }),
@@ -80,7 +82,10 @@ export class BatchKafkaProducer {
         0,
       ),
       topic: this.topic,
+      sendTime: Date.now() - startTime,
     });
+    stats.gauge(`${config.SERVICE_NAME}.kafka_batch_size`, this.currentSize);
+    stats.timing(`${config.SERVICE_NAME}.kafka_batch_send_time`, Date.now() - startTime);
     this.producerMessages = [];
     this.currentSize = 0;
   }

diff --git a/indexer/services/ender/src/lib/batched-handlers.ts b/indexer/services/ender/src/lib/batched-handlers.ts
@@ -100,14 +100,6 @@ export class BatchedHandlers {
       _.forEach(consolidatedKafkaEventGroup, (events: ConsolidatedKafkaEvent[]) => {
         kafkaPublisher.addEvents(events);
       });
-      logger.info({
-        at: 'BatchedHandlers#process',
-        message: 'Finished processing batch of handlers',
-        batchIndex,
-        handlerCountMapping,
-        batchProcessTime: Date.now() - start,
-        batchSize: this.batchedHandlers[batchIndex].length,
-      });
       stats.timing(`${config.SERVICE_NAME}.batch_process_time`, Date.now() - start);
       stats.histogram(`${config.SERVICE_NAME}.batch_size`, this.batchedHandlers[batchIndex].length);
     }

diff --git a/indexer/services/ender/src/lib/on-message.ts b/indexer/services/ender/src/lib/on-message.ts
@@ -73,6 +73,14 @@ export async function onMessage(message: KafkaMessage): Promise<void> {
       topic: KafkaTopics.TO_ENDER,
     },
   );
+  logger.info({
+    at: 'onMessage#onMessage',
+    message: 'Processing message',
+    offset,
+    blockHeight,
+    messageTimeInQueue: start - Number(message.timestamp),
+    numEvents: indexerTendermintBlock.events.length,
+  });
 
   let success: boolean = false;
   const txId: number = await Transaction.start();

diff --git a/indexer/services/ender/src/lib/sync-handlers.ts b/indexer/services/ender/src/lib/sync-handlers.ts
@@ -83,12 +83,6 @@ export class SyncHandlers {
     _.forEach(consolidatedKafkaEventGroup, (events: ConsolidatedKafkaEvent[]) => {
       kafkaPublisher.addEvents(events);
     });
-    logger.info({
-      at: 'SyncHandlers#process',
-      message: 'Finished processing synchronous handlers',
-      handlerCountMapping,
-      batchProcessTime: Date.now() - start,
-    });
     stats.timing(`${config.SERVICE_NAME}.synchronous_events_process_time`, Date.now() - start);
   }
 }