-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
register deprecated vault MsgUpdateParams #2167
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
defc765
to
77beaf8
Compare
// MsgUpdateParams is the Msg/UpdateParams request type. | ||
// Deprecated since v6.x as is replaced by MsgUpdateDefaultQuotingParams. | ||
message MsgUpdateParams { | ||
// Authority is the address that controls the module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Add option deprecated = true;
@Mergifyio backport main |
✅ Backports have been created
|
(cherry picked from commit 9f207d5) # Conflicts: # indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/tx.ts # proto/dydxprotocol/vault/tx.proto # protocol/x/vault/types/tx.pb.go
(cherry picked from commit 9f207d5) Signed-off-by: Tian Qin <[email protected]> # Conflicts: # indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/tx.ts # proto/dydxprotocol/vault/tx.proto # protocol/x/vault/types/tx.pb.go
Co-authored-by: Tian <[email protected]>
Changelist
add deprecated
MsgUpdateParams
back in and register so that existing gov proposals that includeMsgUpdateParams
can successfully unmarshalTest Plan
tested on testnet full node
MsgUpdateParams
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.