fix(market-updater): Fix timing stats #2728

teddyding · 2025-02-25T18:59:54Z

Changelist

[Describe or list the changes made in this PR]

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

Refactor
- Enhanced performance monitoring to capture operation durations more accurately.
- Streamlined task processing by eliminating redundant steps for improved reliability in overall execution.

coderabbitai · 2025-02-25T19:00:02Z

Walkthrough

This change refines the timing mechanism in the runTask function found in the market updater task. It removes the redundant re-initialization of the start time and ensures that both the initial database queries and the overall task execution durations are accurately tracked using timestamps. The logging now immediately follows the queries, providing a clearer measurement of performance.

Changes

File(s)	Change Summary
`indexer/.../market-updater.ts`	Removed redundant `start` variable initialization; consolidated timing logic for initial database queries and overall task execution logging.

Sequence Diagram(s)

sequenceDiagram
    participant Task as runTask
    participant DB as Database
    participant Stats as stats.timing

    Task->>Task: Initialize start time
    Task->>DB: Execute initial queries
    Task->>Stats: Log duration (Date.now() - start)
    Task->>DB: Execute final queries
    Task->>Stats: Log final task duration

Possibly related PRs

Remove unnecessary logs and add Ender metrics #2133: Introduces timing metrics in the getOrderbookMidPriceMap function, aligning with the timing improvements in the current PR.
[OTE-755] Add update wallet total volume roundtable task #2222: Modifies the runTask function in the wallet volume update context, sharing similarities in the timing logic changes.

Suggested labels

indexer, feature:indexer/affiliates

Suggested reviewers

dydxwill
vincentwschau

Poem

I’m a rabbit with a heart so light,
Hopping through code both day and night.
Timers now dance in perfect time,
With every query, a rhythm sublime.
From start to finish, watch me leap –
A merry code rabbit, no more wasted sleep!
🥕🐇

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between edf28be and 2deabb5.

📒 Files selected for processing (1)

indexer/services/roundtable/src/tasks/market-updater.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (14)

GitHub Check: call-build-ecs-service-vulcan / (vulcan) Check docker image build
GitHub Check: call-build-ecs-service-socks / (socks) Check docker image build
GitHub Check: call-build-ecs-service-roundtable / (roundtable) Check docker image build
GitHub Check: call-build-ecs-service-ender / (ender) Check docker image build
GitHub Check: call-build-ecs-service-comlink / (comlink) Check docker image build
GitHub Check: check-build-bazooka
GitHub Check: test / run_command
GitHub Check: check-build-auxo
GitHub Check: lint
GitHub Check: run_command
GitHub Check: Analyze (python)
GitHub Check: Analyze (javascript-typescript)
GitHub Check: Analyze (go)
GitHub Check: Summary

🔇 Additional comments (2)

indexer/services/roundtable/src/tasks/market-updater.ts (2)

49-50: Good initialization of timing variable at function start.

Initializing the start variable at the beginning of the function ensures accurate timing measurements for all operations within the function.

61-65: Good addition of timing metric for initial database queries.

Adding this timing metric immediately after the initial database queries provides more granular performance data. This helps with monitoring and debugging by isolating the time spent on database operations from the rest of the task execution.

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

teddyding · 2025-02-25T19:02:00Z

indexer/services/roundtable/src/tasks/market-updater.ts

@@ -56,7 +58,11 @@ export default async function runTask(): Promise<void> {
  const latestPrices: PriceMap = await OraclePriceTable.getLatestPrices();
  const prices24hAgo: PriceMap = await OraclePriceTable.getPricesFrom24hAgo();

-  const start: number = Date.now();


This should be before initial queries

teddyding · 2025-02-25T19:02:16Z

indexer/services/roundtable/src/tasks/market-updater.ts

@@ -56,7 +58,11 @@ export default async function runTask(): Promise<void> {
  const latestPrices: PriceMap = await OraclePriceTable.getLatestPrices();
  const prices24hAgo: PriceMap = await OraclePriceTable.getPricesFrom24hAgo();

-  const start: number = Date.now();
+  stats.timing(
+    `${config.SERVICE_NAME}.market_updater_initial_queries`,


Measure initial queries specifically

teddyding · 2025-02-25T19:41:41Z

@Mergifyio backport release/indexer/v8.x

mergify · 2025-02-25T19:41:45Z

backport release/indexer/v8.x

✅ Backports have been created

#2729 fix(market-updater): Fix timing stats (backport #2728) has been created for branch release/indexer/v8.x

(cherry picked from commit 8e3b27d)

Co-authored-by: Teddy Ding <[email protected]>

Fix timing stats in market-updator

2deabb5

teddyding requested a review from a team as a code owner February 25, 2025 18:59

github-actions bot added the indexer label Feb 25, 2025

teddyding commented Feb 25, 2025

View reviewed changes

tqin7 approved these changes Feb 25, 2025

View reviewed changes

teddyding merged commit 8e3b27d into main Feb 25, 2025
16 checks passed

teddyding deleted the td/fix-market-updater-timing-stats branch February 25, 2025 19:07

mergify bot pushed a commit that referenced this pull request Feb 25, 2025

fix(market-updater): Fix timing stats (#2728)

6e4f68b

(cherry picked from commit 8e3b27d)

mergify bot mentioned this pull request Feb 25, 2025

fix(market-updater): Fix timing stats (backport #2728) #2729

Merged

6 tasks

teddyding added a commit that referenced this pull request Feb 25, 2025

fix(market-updater): Fix timing stats (backport #2728) (#2729)

c8abe9e

Co-authored-by: Teddy Ding <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(market-updater): Fix timing stats #2728

fix(market-updater): Fix timing stats #2728

teddyding commented Feb 25, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 25, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

teddyding Feb 25, 2025

teddyding Feb 25, 2025

teddyding commented Feb 25, 2025

mergify bot commented Feb 25, 2025 •

edited

Loading

fix(market-updater): Fix timing stats #2728

fix(market-updater): Fix timing stats #2728

Conversation

teddyding commented Feb 25, 2025 • edited by coderabbitai bot Loading

Changelist

Test Plan

Author/Reviewer Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 25, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

teddyding Feb 25, 2025

Choose a reason for hiding this comment

teddyding Feb 25, 2025

Choose a reason for hiding this comment

teddyding commented Feb 25, 2025

mergify bot commented Feb 25, 2025 • edited Loading

✅ Backports have been created

teddyding commented Feb 25, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

mergify bot commented Feb 25, 2025 •

edited

Loading