Remove deprecated setup_requires #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytest-runner is used in a deprecated way: from `setup_requires`. Most of the time this is not an issue, but sometimes it is: when installing the package using pip, `setup_requires` step tries to get `pytest-runner`. And that's the problem: the way `setup_requires` tries to get the missing package is not honoring pip configuration, such as different index, certificates, proxies, etc. Which means the installation of this package can fail in environments where pip needs to be correctly configured to use proxies for Internet access. Additionally, [`pytest-runner` itself says that it is not recommended anymore](https://pypi.org/project/pytest-runner/): > pytest-runner depends on deprecated features of setuptools and relies on features that break security mechanisms in pip. For example ‘setup_requires’ and > ‘tests_require’ bypass pip --require-hashes. See also pypa/setuptools#1684.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest-runneris used in a deprecated way: fromsetup_requires.Most of the time this is not an issue, but sometimes it is: when installing the package using pip,
setup_requiresstep tries to getpytest-runner. And that's the problem: the waysetup_requirestries to get the missing package is not honoring pip configuration, such as different index, certificates, proxies, etc.Which means the installation of this package can fail in environments where pip needs to be correctly configured to use proxies for Internet access.
Additionally,
pytest-runneritself says that it is not recommended anymore: