Generalize input for ModifyCSSFeedbackAction #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| } | ||
|
|
||
| function isStringArray(value: object): value is string[] { |
There was a problem hiding this comment.
I think this method has high re-usability, do you think we can move it in a utility class somewhere?
Adapt `ModifyCSSFeedbackAction` to support both a string[] with the smodel ids or a SModelElement[] as input.
tortmayr
force-pushed
the
tortmayr/fixfeeback
branch
from
4879cf9 to
be53565
Compare
martin-fleck-at
approved these changes
Feb 11, 2021
tortmayr
pushed a commit
that referenced
this pull request
Apr 2, 2021
- Installed and configured ESLint, removed TSLint - Migrated TSLint rules to ESLint were applicable; added additional rules via eslint-plugins (i.e. header, import, no-null) - Updated VSCode settings and extension recommendations - Fix small issues that didn't match the linting rules - Ensure consistent single quote formatting Signed-off-by: Nina Doschek <[email protected]>
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
- Update settings and extension - Fix link to workspace file in README Signed-off-by: Nina Doschek <[email protected]>
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
- Installed and configured ESLint, removed TSLint - Migrated TSLint rules to ESLint were applicable; added additional rules via eslint-plugins (i.e. header, import, no-null) - Updated VSCode settings and extension recommendations - Fix small issues that didn't match the linting rules - Ensure consistent single quote formatting Signed-off-by: Nina Doschek <[email protected]>
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
- Installed and configured ESLint, removed TSLint - Migrated TSLint rules to ESLint were applicable; added additional rules via eslint-plugins (i.e. header, import, no-null) - Updated VSCode settings and extension recommendations - Fix small issues that didn't match the linting rules - Ensure consistent single quote formatting Signed-off-by: Nina Doschek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt
ModifyCSSFeedbackActionto support both a string[] with the smodel ids or a SModelElement[] as input.