GLSP-1054: Rename di.config modules #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `di.config.ts` files to `xyz-module.ts` - Remove default export from di.config files - Remove inconsistent prefixing of modules with `glsp`. All glsp modules are now unprefixed, if a module name conflicts with an existing sprotty module, the sprotty module is reexported with a `sprotty` prefix - Aligned/renamed some module names Also: - Move `focus-change-action` and `focus-tracker` to `focus` subdirectory Fixes eclipse-glsp/glsp#1054
planger
reviewed
Jul 14, 2023
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
* GLSP-1054: Rename di.config modules - Rename `di.config.ts` files to `xyz-module.ts` - Remove default export from di.config files - Remove inconsistent prefixing of modules with `glsp`. All glsp modules are now unprefixed, if a module name conflicts with an existing sprotty module, the sprotty module is reexported with a `sprotty` prefix - Aligned/renamed some module names Also: - Move `focus-change-action` and `focus-tracker` to `focus` subdirectory Fixes eclipse-glsp/glsp#1054
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
* GLSP-1054: Rename di.config modules - Rename `di.config.ts` files to `xyz-module.ts` - Remove default export from di.config files - Remove inconsistent prefixing of modules with `glsp`. All glsp modules are now unprefixed, if a module name conflicts with an existing sprotty module, the sprotty module is reexported with a `sprotty` prefix - Aligned/renamed some module names Also: - Move `focus-change-action` and `focus-tracker` to `focus` subdirectory Fixes eclipse-glsp/glsp#1054
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
di.config.tsfiles toxyz-module.tsglsp. All glsp modules are now unprefixed, if a module name conflicts with an existing sprotty module, the sprotty module is reexported with asprottyprefixAlso:
focus-change-actionandfocus-trackertofocussubdirectoryFixes eclipse-glsp/glsp#1054