Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between live and batch validation #43

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

planger
Copy link
Member

@planger planger commented Apr 24, 2023

eclipse-glsp/glsp#980

Corresponding change for Java server: eclipse-glsp/glsp-server#200

@planger planger requested a review from tortmayr April 24, 2023 14:15
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.
I only have to minor nitpicks, that could be improved but do not prevent merging

eclipse-glsp/glsp#980

Apply suggestions from code review

Co-authored-by: Tobias Ortmayr <[email protected]>
@planger planger force-pushed the planger/issues/980 branch from 07c94a5 to 5015e90 Compare May 3, 2023 17:50
@planger planger merged commit 146ae06 into main May 3, 2023
@planger planger deleted the planger/issues/980 branch May 3, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants