Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSP-847 Drop dependency to sprotty-theia #149

Merged
merged 3 commits into from
Mar 16, 2023
Merged

GLSP-847 Drop dependency to sprotty-theia #149

merged 3 commits into from
Mar 16, 2023

Conversation

tortmayr
Copy link
Contributor

Drop dependency to sprotty-theia , move dependent code in-repo and adapt existing code base.
Code that is adapted from the orginal sprotty-theia repository is proplery marked in the copyright notice and with an inline comment

Depends on: #146
Fixes eclipse-glsp/glsp#847

Drop dependency to sprotty-theia , move dependent code in-repo and adapt existing code base.
Code that is adapted from the orginal sprotty-theia repository is proplery marked in the copyright notice and with an inline comment

Depends on: #146
Fixes eclipse-glsp/glsp#847
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tortmayr for this change! The code looks mostly good to me. However, it seems that somewhere along the way something broke:

  • Undo/Redo not working properly
  • Copy/Paste not working properly
  • The 'Diagram' menu entries in Theia are also not working as expected

They probably all have the same source because I can see the following errors in the console:
root ERROR Error: No matching bindings found for serviceIdentifier: Symbol(SelectionService)
and
Error: No matching bindings found for serviceIdentifier: EditorContextService

Maybe it is something on my end but everything builds normally, there are no additional yarn.lock changes, and the master branch works as expected. Could you please have a look at this?

@tortmayr
Copy link
Contributor Author

Thanks for the review Martin. There was a mixup in the yarn.lock file and we ended up with two different glps-client versions....
I ran the upgrade script again and now everything seems to work.

Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tortmayr Yeah, that was it! Thanks for the quick update. Everything seems to work very well now. LGTM!

@tortmayr tortmayr merged commit 4fd7e64 into master Mar 16, 2023
@tortmayr tortmayr deleted the issues/847 branch March 16, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop dependency to sprotty-theia
2 participants