-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup markers on close & consider marker reason #153
Conversation
Build failure is expected as it depends on the protocol change:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Philip, support for live validation is definitely a nice feature addition.
I did not have time to test the changes yet and only did a preliminary code review for now.
packages/theia-integration/src/browser/diagram/theia-marker-manager.ts
Outdated
Show resolved
Hide resolved
packages/theia-integration/src/browser/diagram/theia-marker-manager.ts
Outdated
Show resolved
Hide resolved
packages/theia-integration/src/browser/diagram/theia-marker-manager.ts
Outdated
Show resolved
Hide resolved
packages/theia-integration/src/browser/diagram/theia-marker-manager.ts
Outdated
Show resolved
Hide resolved
Thank you for the swift and excellent review! I've applied your suggestions in 3836bb7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Once the client change is merged we can update the locked version and merge this aswell.
Idea for a follow-up issue/feature: |
Good idea, I've tracked it here for now: eclipse-glsp/glsp#980 (comment) @tortmayr Also, can you please re-check f4eab49 in which I've upgraded the |
With this change, we clean-up all markers on close of a diagram widget but only keep by default those markers that have been added by a live validation. eclipse-glsp/glsp#980 Change-Id: I62e515505a4a4afeed1d187393a471073d22a089 Add changelog entry Change-Id: I2240f8aefc41eba2c0931edeecb44963d26a5d50 Apply suggestions from review Change-Id: Ifee3b99c61066d03057cf107e6d22b5cfd8aa806 Update yarn.lock Change-Id: I268c7230cf24e78fe59ffbf1c1abfd3ea67ba8a8 Resolve yarn.lock Change-Id: I21555351d382d68f04b8e44e020aa580783bcf0a
f4eab49
to
d7a5e42
Compare
With this change, we clean-up all markers on close of a diagram widget but only keep by default those markers that have been added by a live validation.
eclipse-glsp/glsp#980
For review, please see the comment on which changes belong together.
Change-Id: I62e515505a4a4afeed1d187393a471073d22a089