Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding arguments to SModelElements #194

Closed
planger opened this issue Feb 23, 2021 · 2 comments
Closed

Support adding arguments to SModelElements #194

planger opened this issue Feb 23, 2021 · 2 comments
Assignees
Labels

Comments

@planger
Copy link
Member

planger commented Feb 23, 2021

We encountered a few scenarios where we would like to add data to the GModel, but extending GModel types seemed as an overkill for those use cases. Instead, it would be more convenient to just have an arguments map for elements to transfer certain information from the server to the client.

@planger planger added enhancement New feature or request server-java client labels Feb 23, 2021
@planger planger self-assigned this Feb 23, 2021
planger added a commit to eclipse-glsp/glsp-server that referenced this issue Feb 23, 2021
This allows to transfer custom information from the server to the client
in the GModel without having to extend the GModel types with custom
classes.

E.g.
    modelState.getRoot().getArgs().put("test", true);
    modelState.getRoot().getArgs().put("test2", "a string 2");

eclipse-glsp/glsp#194
planger added a commit to eclipse-glsp/glsp-client that referenced this issue Feb 23, 2021
tortmayr pushed a commit to eclipse-glsp/glsp-client that referenced this issue Mar 1, 2021
* Add SArgumentable interface denoting elements that contain args

eclipse-glsp/glsp#194
tortmayr pushed a commit to eclipse-glsp/glsp-server that referenced this issue Mar 1, 2021
* Add args to SModelElements

This allows to transfer custom information from the server to the client
in the GModel without having to extend the GModel types with custom
classes.

E.g.
    modelState.getRoot().getArgs().put("test", true);
    modelState.getRoot().getArgs().put("test2", "a string 2");

eclipse-glsp/glsp#194

* Update genmodel copyright year and regenerate new classes
@tortmayr
Copy link
Contributor

@planger Can we close this? I think this is already merged

@planger
Copy link
Member Author

planger commented Mar 23, 2021

Right, all is done in this regard. Thanks!

@planger planger closed this as completed Mar 23, 2021
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this issue Dec 21, 2024
* Add args to SModelElements

This allows to transfer custom information from the server to the client
in the GModel without having to extend the GModel types with custom
classes.

E.g.
    modelState.getRoot().getArgs().put("test", true);
    modelState.getRoot().getArgs().put("test2", "a string 2");

eclipse-glsp/glsp#194

* Update genmodel copyright year and regenerate new classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants