Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and refine publisher and subscriber API #23

Closed
3 of 4 tasks
elBoberido opened this issue Jun 21, 2022 · 0 comments · Fixed by #24 or #46
Closed
3 of 4 tasks

Update and refine publisher and subscriber API #23

elBoberido opened this issue Jun 21, 2022 · 0 comments · Fixed by #24 or #46
Assignees

Comments

@elBoberido
Copy link
Member

elBoberido commented Jun 21, 2022

Brief feature description

The current API was crafted before the iceoryx v1 release and does not fit the changes introduced with v1 and v2 quite well.

Additionally, there are some new publisher and subscriber options which should also be supported by the Rust binding.

Detailed information

  • Adjust the publisher and subscriber options to match iceoryx v2
  • Replace the pb::Topic and pb::TopicBuilder structs with InactivePublisher and PublisherBuilder with the option to create publisher to offer on create
  • Replace the sb::Topic and sb::TopicBuilder structs with InactiveSubscriber and SubscriberBuilder with the option to create subscriber to subscribe on create
  • Align the naming to the iceoryx C++ API as much as possible, e.g. use loan instead of allocate_sample
@elBoberido elBoberido self-assigned this Jun 21, 2022
elBoberido added a commit that referenced this issue Jun 21, 2022
elBoberido added a commit that referenced this issue Jun 21, 2022
elBoberido added a commit that referenced this issue Jun 21, 2022
elBoberido added a commit that referenced this issue Jun 25, 2022
elBoberido added a commit that referenced this issue Jun 25, 2022
elBoberido added a commit that referenced this issue Jun 25, 2022
elBoberido added a commit that referenced this issue Jun 25, 2022
elBoberido added a commit that referenced this issue Jun 25, 2022
elBoberido added a commit that referenced this issue Jun 25, 2022
elBoberido added a commit that referenced this issue Jun 27, 2022
elBoberido added a commit that referenced this issue Jun 27, 2022
elBoberido added a commit that referenced this issue Jun 27, 2022
elBoberido added a commit that referenced this issue Jun 27, 2022
elBoberido added a commit that referenced this issue Jun 27, 2022
elBoberido added a commit that referenced this issue Jun 27, 2022
elBoberido added a commit that referenced this issue Jun 27, 2022
elBoberido added a commit that referenced this issue Jun 27, 2022
elBoberido added a commit that referenced this issue Jun 27, 2022
elBoberido added a commit that referenced this issue Jun 27, 2022
elBoberido added a commit that referenced this issue Jun 27, 2022
@elBoberido elBoberido reopened this Jun 28, 2022
elBoberido added a commit that referenced this issue Jun 30, 2022
elBoberido added a commit that referenced this issue Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant