Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2420 Add missing header <chrono> #2422

Open
wants to merge 1 commit into
base: release_2.0
Choose a base branch
from

Conversation

mjcarroll
Copy link

@mjcarroll mjcarroll commented Feb 21, 2025

Not including this header leads to compilation errors about missing symbols/templates under VS2022 on Windows.

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Not including this header leads to compilation errors about missing
symbols/templates under VS2022 on Windows.

Signed-off-by: Michael Carroll <[email protected]>
@elBoberido
Copy link
Member

@mjcarroll this is fixed on main, but was not backported. Thanks for taking care of this :)

@mjcarroll
Copy link
Author

No problem, just caught it when testing ROS 2 installation instructions on MSVC2022/Win11: ros2/ros2_documentation#4989

@elBoberido
Copy link
Member

Oh, it seems there is an issue with the macOS CI. I can have a look at that at the weekend, if this is not pressing.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.84%. Comparing base (a4a1157) to head (ee28b63).
Report is 1 commits behind head on release_2.0.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release_2.0    #2422      +/-   ##
===============================================
+ Coverage        78.47%   78.84%   +0.37%     
===============================================
  Files              370      370              
  Lines            14219    14715     +496     
  Branches          2060     2060              
===============================================
+ Hits             11158    11602     +444     
- Misses            2377     2430      +53     
+ Partials           684      683       -1     
Flag Coverage Δ
unittests 78.06% <ø> (+0.35%) ⬆️
unittests_timing 15.48% <ø> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 149 files with indirect coverage changes

@elBoberido
Copy link
Member

@mjcarroll the macOS CI is now fixed on the release_2.0 branch. Please rebase and also update the changelog with the issue that is closed by this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Solves a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants