Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Theia AI] Hashtags always autocomplete in the chat #15028

Open
Tracked by #14923
JonasHelming opened this issue Feb 25, 2025 · 0 comments · May be fixed by #15030
Open
Tracked by #14923

[Theia AI] Hashtags always autocomplete in the chat #15028

JonasHelming opened this issue Feb 25, 2025 · 0 comments · May be fixed by #15030

Comments

@JonasHelming
Copy link
Contributor

JonasHelming commented Feb 25, 2025 •
edited
Loading

They should only autocomplete when it’s the first character of the line or if a space precedes them, e.g. I can’t type “foo#bar” without triggering autocomplete on variables.
@JonasHelming JonasHelming mentioned this issue Feb 25, 2025
Open
56 tasks
eneufeld added a commit to eclipsesource/theia that referenced this issue Feb 25, 2025
@eneufeld
Fix: Prevent autocompletion from triggering incorrectly within words
8770084 
This commit fixes an issue where autocompletion would incorrectly trigger when typing a variable character '#' in the middle of words (e.g., "Hello#").

Changes:
- Removed '#' from trigger characters in the variable argument completion provider
- Improved boundary detection in the variable argument picker to prevent triggering when '#' appears within words
- Added better context validation to ensure completion only happens in appropriate cases
- Fixed the implementation to maintain correct functionality for legitimate variable references like "#file:"

The fix ensures that autocompletion is only triggered in intended contexts while preserving all existing functionality.
Fixed eclipse-theia#15028
@eneufeld eneufeld linked a pull request Feb 25, 2025 that will close this issue
Open
2 tasks
@JonasHelming JonasHelming changed the title [Theia AI] Hashtags always autocomplete in the chat | They should only autocomplete when it’s the first character of the line or if a space precedes them, e.g. I can’t type “foo#bar” without triggering autocomplete on variables. [Theia AI] Hashtags always autocomplete in the chat Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Prevent autocompletion from triggering incorrectly within words eclipsesource/theia
1 participant
@JonasHelming