Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create a model reference for inline editors #14942

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

tsmaeder
Copy link
Contributor

What it does

Fixes #14924

How to test

Make sure all our uses of text editors (regular editors, notebook, output view, chat input) work as expected. Make sure the original problem (#14880) stays fixed on Linux.

Follow-ups

We should investigate the root causes both in the chat input widget layout as well as our text model management that caused this problem.

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Contributed on behalf of STMicroelectronics

Review checklist

Reminder for reviewers

Fixes eclipse-theia#14924

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder tsmaeder requested review from msujew and sdirix February 17, 2025 11:03
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see any regression, the original issue is still fixed and the chat input works again. Thanks!

@tsmaeder
Copy link
Contributor Author

The error in the failing PR check is

@theia/core: free(): double free detected in tcache 2
@theia/core: node:internal/errors:540
@theia/core:       throw error;
@theia/core:       ^
@theia/core: TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received type string ('128SIGABRT')
@theia/core:     at process.set [as exitCode] (node:internal/bootstrap/node:123:9)
@theia/core:     at ChildProcess.<anonymous> (/home/runner/work/theia/theia/node_modules/foreground-child/index.js:63:22)
@theia/core:     at ChildProcess.emit (node:events:524:28)
@theia/core:     at maybeClose (node:internal/child_process:1101:16)
@theia/core:     at ChildProcess._handle.onexit (node:internal/child_process:304:5) {
@theia/core:   code: 'ERR_INVALID_ARG_TYPE'
@theia/core: }

I've seen this error before and it eventually goes away when trying long enough. It is highly unlikely that it is related to this PR.

@tsmaeder tsmaeder merged commit 0419c0a into eclipse-theia:master Feb 17, 2025
10 of 11 checks passed
@github-actions github-actions bot added this to the 1.59.0 milestone Feb 17, 2025
tsmaeder added a commit that referenced this pull request Feb 17, 2025
Fixes #14924

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@planger planger mentioned this pull request Feb 17, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Chat Input is unusable
2 participants