Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provide open handler for quick file open #15003

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

planger
Copy link
Contributor

@planger planger commented Feb 21, 2025

What it does

Adds the open handler also for recent files when creating the quick pick item. This was an oversight in the refactoring that was part of #14787.

Fixes #15002

How to test

Check if the steps reported in #15002 now work correctly.

Follow-ups

None

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

None

Review checklist

Reminder for reviewers

Adds the open handler also for recent files when creating the quick pick item. This was an oversight in the refactoring that was part of #14787.

Fixes #15002
@planger planger requested a review from sdirix February 21, 2025 14:51
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@planger planger merged commit b7a3241 into master Feb 21, 2025
10 of 11 checks passed
@planger planger deleted the planger/issues/15002 branch February 21, 2025 15:27
@github-actions github-actions bot added this to the 1.59.0 milestone Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

File Picker: Recently opened files are no longer opened
2 participants