Change default memory allocation policy and size of the queue #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyfo
reviewed
Feb 3, 2025
| data: 4, | ||
| data_low: 4, | ||
| background: 4, | ||
| data: 2, |
There was a problem hiding this comment.
I think this would impact maximum throughput by a lot.
There was a problem hiding this comment.
In my tests I have observed no difference whatsoever... do you observe the same?
8 bytes payload
2 batches
4407172.419259213 msg/s
4343720.114696581 msg/s
4314540.555551352 msg/s
4345756.231605296 msg/s
4338680.473918537 msg/s
4396559.932344768 msg/s
4390461.760899556 msg/s
4377899.688177528 msg/s
4367711.594203114 msg/s
4345347.717885626 msg/s
4 batches
4327679.108419167 msg/s
4389556.194952455 msg/s
4391946.247048938 msg/s
4387449.76094437 msg/s
4315384.108078019 msg/s
4284134.162390979 msg/s
4373345.570887221 msg/s
4397007.707862175 msg/s
4394504.808406187 msg/s
4397692.482819417 msg/s
8192 bytes payload
2 batches
1031180.5019144053 msg/s
1007955.1255636461 msg/s
784623.0171142459 msg/s
837900.7582968347 msg/s
832838.3525152829 msg/s
839854.0857332004 msg/s
921410.3438061457 msg/s
966730.9136375008 msg/s
973037.7477276628 msg/s
958199.2045687528 msg/s
4 batches
1003310.7217095651 msg/s
872120.1753484475 msg/s
997713.8235789438 msg/s
996013.6059402785 msg/s
940227.5416278623 msg/s
876295.9229319188 msg/s
880288.7161776316 msg/s
882700.0310307016 msg/s
862598.8748784737 msg/s
880920.6895369346 msg/s
1M bytes payload
2 batches
7613.407554525003 msg/s
7345.827099413475 msg/s
7597.320740415613 msg/s
7392.356154115356 msg/s
7305.849481062188 msg/s
7659.214160399257 msg/s
7678.778134148506 msg/s
7346.802021237772 msg/s
7560.669783798256 msg/s
7560.8326639161105 msg/s
4 batches
7829.248873567797 msg/s
7471.750145798876 msg/s
7640.854016786412 msg/s
7521.376140221726 msg/s
7778.550286349516 msg/s
7496.163397981484 msg/s
7676.226735395762 msg/s
7408.409743294831 msg/s
7661.548924880467 msg/s
7679.129567591862 msg/s
There was a problem hiding this comment.
Indeed, it doesn't seems to change the throughput. Then I'm quite confused with my previous "allocation on demand" experiment that enabled 1Mmsg/s increase ...
There was a problem hiding this comment.
Here I tested on an AMD Ryzen 7 5800X 8-Core Processor, so maybe different architecture?
In any case, the difference seems to be on the positive side at the moment.
wyfo
approved these changes
Feb 3, 2025
JEnoch
added a commit
to ZettaScaleLabs/rmw_zenoh
that referenced
this pull request
Feb 4, 2025
Yadunund
added a commit
to ros2/rmw_zenoh
that referenced
this pull request
Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41 * Config: add new gossip target setting (eclipse-zenoh/zenoh#1678) * Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710) * Config: copy updates from eclipse-zenoh/zenoh#1712 * Config: copy updates from eclipse-zenoh/zenoh#1722 * Config: copy updates from eclipse-zenoh/zenoh#1749 * Config: copy updates from eclipse-zenoh/zenoh#1751 * fix: use the commit 15d56e1 to include the allocation feature * Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0) * Update documentation for commits and undo style changes Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]> Co-authored-by: yuanyuyuan <[email protected]> Co-authored-by: Yadunund <[email protected]>
mergify bot
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41 * Config: add new gossip target setting (eclipse-zenoh/zenoh#1678) * Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710) * Config: copy updates from eclipse-zenoh/zenoh#1712 * Config: copy updates from eclipse-zenoh/zenoh#1722 * Config: copy updates from eclipse-zenoh/zenoh#1749 * Config: copy updates from eclipse-zenoh/zenoh#1751 * fix: use the commit 15d56e1 to include the allocation feature * Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0) * Update documentation for commits and undo style changes Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]> Co-authored-by: yuanyuyuan <[email protected]> Co-authored-by: Yadunund <[email protected]> (cherry picked from commit d322d6f)
mergify bot
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41 * Config: add new gossip target setting (eclipse-zenoh/zenoh#1678) * Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710) * Config: copy updates from eclipse-zenoh/zenoh#1712 * Config: copy updates from eclipse-zenoh/zenoh#1722 * Config: copy updates from eclipse-zenoh/zenoh#1749 * Config: copy updates from eclipse-zenoh/zenoh#1751 * fix: use the commit 15d56e1 to include the allocation feature * Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0) * Update documentation for commits and undo style changes Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]> Co-authored-by: yuanyuyuan <[email protected]> Co-authored-by: Yadunund <[email protected]> (cherry picked from commit d322d6f)
Yadunund
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41 * Config: add new gossip target setting (eclipse-zenoh/zenoh#1678) * Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710) * Config: copy updates from eclipse-zenoh/zenoh#1712 * Config: copy updates from eclipse-zenoh/zenoh#1722 * Config: copy updates from eclipse-zenoh/zenoh#1749 * Config: copy updates from eclipse-zenoh/zenoh#1751 * fix: use the commit 15d56e1 to include the allocation feature * Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0) * Update documentation for commits and undo style changes Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]> Co-authored-by: yuanyuyuan <[email protected]> Co-authored-by: Yadunund <[email protected]> (cherry picked from commit d322d6f) Co-authored-by: Julien Enoch <[email protected]>
Yadunund
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41 * Config: add new gossip target setting (eclipse-zenoh/zenoh#1678) * Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710) * Config: copy updates from eclipse-zenoh/zenoh#1712 * Config: copy updates from eclipse-zenoh/zenoh#1722 * Config: copy updates from eclipse-zenoh/zenoh#1749 * Config: copy updates from eclipse-zenoh/zenoh#1751 * fix: use the commit 15d56e1 to include the allocation feature * Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0) * Update documentation for commits and undo style changes Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]> Co-authored-by: yuanyuyuan <[email protected]> Co-authored-by: Yadunund <[email protected]> (cherry picked from commit d322d6f) Co-authored-by: Julien Enoch <[email protected]>
wyfo
added a commit
to ZettaScaleLabs/zenoh
that referenced
this pull request
Feb 10, 2025
wyfo
added a commit
to ZettaScaleLabs/zenoh
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default configuration now:
overall reducing memory consumption out-of-the-box.