-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the pipeline: batch allocation + deterministic backoff #1769
base: main
Are you sure you want to change the base?
Changes from all commits
cc50515
085b0e7
64a78c7
5a727ac
f4b0c8a
8b39e0c
5babf83
d9b7459
039045c
e9a4307
a6d569b
d293e85
c87f99c
133dccd
f894f63
6965cde
524cf7b
88f07b0
c136ac7
adc456b
35ff64c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -471,14 +471,14 @@ | |
/// then amount of memory being allocated for each queue is SIZE_XXX * LINK_MTU. | ||
/// If qos is false, then only the DATA priority will be allocated. | ||
size: { | ||
control: 2, | ||
real_time: 2, | ||
interactive_high: 2, | ||
interactive_low: 2, | ||
control: 1, | ||
real_time: 1, | ||
interactive_high: 1, | ||
interactive_low: 1, | ||
data_high: 2, | ||
data: 2, | ||
data_low: 2, | ||
background: 2, | ||
data: 4, | ||
data_low: 4, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The numbers are not coherent with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're right, good catch ! |
||
background: 4, | ||
}, | ||
/// Congestion occurs when the queue is empty (no available batch). | ||
congestion_control: { | ||
|
@@ -506,12 +506,6 @@ | |
/// The maximum time limit (in ms) a message should be retained for batching when back-pressure happens. | ||
time_limit: 1, | ||
}, | ||
allocation: { | ||
/// Mode for memory allocation of batches in the priority queues. | ||
/// - "init": batches are allocated at queue initialization time. | ||
/// - "lazy": batches are allocated when needed up to the maximum number of batches configured in the size configuration parameter. | ||
mode: "lazy", | ||
}, | ||
}, | ||
}, | ||
/// Configure the zenoh RX parameters of a link | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reverted the previous commit, so the numbers are back to the original ones. Throughputs of big messages was indeed very impacted by a smaller batch number, 130kmsg/s -> 50kmsg/s for 70kB messages.
@Mallets Do you think we should modify the numbers? for example increasing the hight priority to 2? In fact this PR does lazy allocation, and only keep one buffer in memory, so we could put any numbers, it would not change memory consumption at all, it just a matter of throughput/congestion.