1. fix: 修复 Table 组件单独引入时分页功能没有样式的问题；2. docs: 修改示例代码的一处不影响功能的错误；3. fix: 修复 TimePicker 组件无法用首字母大写的形式引入的问题。 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinzhan
reviewed
Mar 29, 2021
| import './index.less'; | ||
| import '../../pagination/style/index'; |
There was a problem hiding this comment.
这个地方有点问题，这个style应该是跟pagination.js放到一起，这么引就显得模块化设计做的不好
There was a problem hiding this comment.
每个组件自己会引自己的style，如果某个组件还依赖其它组件的style，那就会再引入其它组件的style。
There was a problem hiding this comment.
合理的设计应该是组件依赖其他组件，不需要再额外显示去引入style
Lohoyo
changed the title
Lohoyo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.