Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLM 724 #1286

Merged
merged 6 commits into from
Oct 20, 2022
Merged

HLM 724 #1286

merged 6 commits into from
Oct 20, 2022

Conversation

vishwajeet-eGov
Copy link
Collaborator

@saiprakash-v @prasanna-egov Please review.

saiprakash-v
saiprakash-v reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@saiprakash-v saiprakash-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for the "Router upgrade" PR to be addressed and closed before reviewing this. There are duplicate changes

@saiprakash-v
Copy link
Contributor

@vishwajeet-eGov Please remove the duplicate changes and let me know. I will review

@vishwajeet-eGov
Copy link
Collaborator Author

@saiprakash-v Conflict resolved.

prasanna-egov
prasanna-egov reviewed Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@prasanna-egov prasanna-egov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the user profile image, please get the appropriate language from Andrew.

@prasanna-egov prasanna-egov merged commit d8b80b2 into egovernments:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saiprakash-v saiprakash-v saiprakash-v approved these changes

@prasanna-egov prasanna-egov prasanna-egov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vishwajeet-eGov @saiprakash-v @prasanna-egov @vishi24