Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include serialization in benchmarking #521

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saulshanabrook
Copy link
Member

I extracted on line from #520 to see how much adding serialization adds to our benchmark and make that one clearer how much performance it gains!

@saulshanabrook saulshanabrook requested a review from a team as a code owner February 14, 2025 21:38
@saulshanabrook saulshanabrook requested review from FTRobbin and removed request for a team February 14, 2025 21:38
Copy link

codspeed-hq bot commented Feb 14, 2025

CodSpeed Performance Report

Merging #521 will degrade performances by 99.18%

Comparing saulshanabrook:benchmark-serialization (e5a43ea) with main (215714e)

Summary

❌ 5 (👁 5) regressions
✅ 5 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
👁 cykjson 378.1 ms 8,065.9 ms -95.31%
👁 eggcc-extraction 2.2 s 29.6 s -92.51%
👁 extract-vec-bench 74 ms 9,050.1 ms -99.18%
👁 math-microbenchmark 4.3 s 55.7 s -92.35%
👁 python_array_optimize 3.9 s 60.9 s -93.67%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant