[Heartbeat] fix minor unreachable code (#32659)

Signed-off-by: Abirdcfly <[email protected]>
elastic · Jun 1, 2023 · c548086 · c548086
1 parent f66c196
commit c548086
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/filebeat/input/file/glob_test.go b/filebeat/input/file/glob_test.go
@@ -34,13 +34,14 @@ func TestGlob(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	os.MkdirAll(filepath.Join(root, "foo/bar/baz/qux/quux"), 0o755)
+	if err := os.MkdirAll(filepath.Join(root, "foo/bar/baz/qux/quux"), 0o755); err != nil {
+		t.Fatal(err)
+	}
 	for _, test := range globTests {
 		pattern := filepath.Join(root, test.pattern)
 		matches, err := Glob(pattern, 4)
 		if err != nil {
 			t.Fatal(err)
-			continue
 		}
 		var normalizedMatches []string
 		for _, m := range matches {
@@ -92,7 +93,6 @@ func TestGlobPatterns(t *testing.T) {
 		for i, p := range patterns {
 			if p != test.expectedPatterns[i] {
 				t.Fatalf("%q expanded to %q instead of %q", test.pattern, patterns, test.expectedPatterns)
-				break
 			}
 		}
 	}

diff --git a/filebeat/input/syslog/rfc3164_test.go b/filebeat/input/syslog/rfc3164_test.go
@@ -793,7 +793,6 @@ func TestPriority(t *testing.T) {
 			ParserRFC3164([]byte(log), l)
 			assert.Equal(t, d, l.Priority())
 		})
-		return
 	}
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -793,7 +793,6 @@ func TestPriority(t *testing.T) { @@
     			ParserRFC3164([]byte(log), l)
     			assert.Equal(t, d, l.Priority())
     		})
-    		return
     	}
     }
@@ Expand Down @@