Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Fix flaky test in Elasticsearch module #10874

Merged
merged 1 commit into from
Feb 22, 2019
Merged

[Metricbeat] Fix flaky test in Elasticsearch module #10874

merged 1 commit into from
Feb 22, 2019

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Feb 21, 2019

Two things in this PR:

12:02:17 command [go test -race -tags integration -cover -coverprofile /tmp/gotestcover-701860008 github.com/elastic/beats/metricbeat/module/elasticsearch]: exit status 1
12:02:17 Building elasticsearch
12:02:17 Step 1/2 : FROM docker.elastic.co/elasticsearch/elasticsearch:6.6.0
12:02:17  ---> 13aa43015aa1
12:02:17 Step 2/2 : HEALTHCHECK --interval=1s --retries=300 CMD curl -f http://localhost:9200/_xpack/license
12:02:17  ---> Using cache
12:02:17  ---> d9b59c3116c3
12:02:17 Successfully built d9b59c3116c3
12:02:17 Successfully tagged metricbeat97f33c937432dee1235f6e4e23541a95e5cab575_elasticsearch:latest
12:02:17 Creating metricbeat97f33c937432dee1235f6e4e23541a95e5cab575_elasticsearch_1 ... 
12:02:17 
12:02:17 Creating metricbeat97f33c937432dee1235f6e4e23541a95e5cab575_elasticsearch_1 ... done
12:02:17 --- FAIL: TestFetch (72.40s)
12:02:17 panic: runtime error: invalid memory address or nil pointer dereference [recovered]
12:02:17 	panic: runtime error: invalid memory address or nil pointer dereference
12:02:17 [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0xa2f906]
12:02:17 
12:02:17 goroutine 18 [running]:
12:02:17 testing.tRunner.func1(0xc42035a0f0)
12:02:17 	/usr/local/go/src/testing/testing.go:742 +0x567
12:02:17 panic(0xac1300, 0xe882d0)
12:02:17 	/usr/local/go/src/runtime/panic.go:502 +0x24a
12:02:17 github.com/elastic/beats/metricbeat/module/elasticsearch_test.createMLJob(0xc42014a180, 0x12, 0xc42014e700, 0x0, 0x0)
12:02:17 	/go/src/github.com/elastic/beats/metricbeat/module/elasticsearch/elasticsearch_integration_test.go:230 +0x1e6
12:02:17 github.com/elastic/beats/metricbeat/module/elasticsearch_test.TestFetch(0xc42035a0f0)
12:02:17 	/go/src/github.com/elastic/beats/metricbeat/module/elasticsearch/elasticsearch_integration_test.go:77 +0x2c7
12:02:17 testing.tRunner(0xc42035a0f0, 0xb73ff0)
12:02:17 	/usr/local/go/src/testing/testing.go:777 +0x16e
12:02:17 created by testing.(*T).Run
12:02:17 	/usr/local/go/src/testing/testing.go:824 +0x565
12:02:17 FAIL	github.com/elastic/beats/metricbeat/module/elasticsearch	72.544s

@sayden sayden added Metricbeat Metricbeat flaky-test Unstable or unreliable test cases. Team:Integrations Label for the Integrations team labels Feb 21, 2019
@sayden sayden self-assigned this Feb 21, 2019
@sayden sayden requested a review from a team as a code owner February 21, 2019 20:46
@sayden sayden force-pushed the bugfix/mb/improve-es-module-tests branch from 42664b1 to 60f10a6 Compare February 21, 2019 22:10
cachedout
cachedout approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@cachedout cachedout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sayden sayden merged commit 78446a9 into elastic:master Feb 22, 2019
@fearful-symmetry fearful-symmetry mentioned this pull request Mar 6, 2019
Closed
This was referenced Jun 6, 2019
Merged
Merged
ycombinator added a commit that referenced this pull request Jun 6, 2019
@ycombinator
[6.8] Fix flaky test in Elasticsearch module (#10874) (#12463)
b944fea 
An unhandled error was causing panics under certain circumstances
ycombinator added a commit that referenced this pull request Jun 7, 2019
@ycombinator
[7.1] Fix flaky test in Elasticsearch module (#10874) (#12462)
687e929 
An unhandled error was causing panics under certain circumstances
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@ycombinator
[7.1] Fix flaky test in Elasticsearch module (elastic#10874) (elastic…
05c9980 
…#12462)

An unhandled error was causing panics under certain circumstances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachedout cachedout cachedout approved these changes

Assignees

@sayden sayden

Labels
flaky-test Unstable or unreliable test cases. Metricbeat Metricbeat Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sayden @cachedout