Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mongodb OP_MSG (2013) #11500

Merged
merged 3 commits into from
Apr 1, 2019
Merged

add mongodb OP_MSG (2013) #11500

merged 3 commits into from
Apr 1, 2019

Conversation

pohzipohzi
Copy link

this fixes #6191

this is a continuation of #8594 after running into problems with the CLA. It was created by saving changes onto a patch and applying them onto a new branch opc2

git diff origin/master... --binary > ~/Desktop/useful/beats.patch
git checkout master
git branch -b opc2
git apply ~/Desktop/useful/beats.patch
(commit and make PR)

@pohzipohzi pohzipohzi requested review from a team as code owners March 28, 2019 00:12
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@pohzipohzi
Copy link
Author

@adriansr could you help to review this?

I'm removing this changes probably added by the IDE due line-length limitations.
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to finish this feature.

I found a small problem, everything else is correct.

Also, I took the liberty to edit some formatting changes to beat.py that were probably added by your editor.

@adriansr adriansr merged commit 89bf75c into elastic:master Apr 1, 2019
@pohzipohzi pohzipohzi deleted the opc2 branch April 1, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants