Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auditbeat] Socket dataset: Exclude localhost by default #11993

Merged
merged 10 commits into from
May 2, 2019

Conversation

cwurm
Copy link
Contributor

@cwurm cwurm commented Apr 30, 2019

Adds a new configuration option socket.include_localhost to control if sockets from or to localhost/loopback should be included. It defaults to false to reduce the large amount of data the dataset produces.

I also took the opportunity to clean up, organize, and expand the unit tests - the tests are now TestData, TestOutbound (connects to google.com:80), TestListening, TestLocalhost, and TestLocalhostExcluded.

I also added a section Implementation to the docs with a blurb about how the socket dataset works on Linux.

This is a breaking change since it changes what the socket dataset reports by default. It's worth doing in a minor release IMO since the dataset is quite noisy and the value of local connections is questionable. The current functionality can be restored by setting socket.include_localhost: true.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/secops

@andrewkroh
Copy link
Member

jenkins test this

@andrewkroh
Copy link
Member

andrewkroh commented May 1, 2019

There is a test failure at https://travis-ci.org/elastic/beats/jobs/526384523#L748-L762.

@cwurm
Copy link
Contributor Author

cwurm commented May 2, 2019

There is a test failure at travis-ci.org/elastic/beats/jobs/526384523#L748-L762.

Thanks, fixed it. The cause was that without local sockets, the integration tests produce no data.

CI is green now, merging.

@cwurm cwurm merged commit 149e020 into elastic:master May 2, 2019
@cwurm cwurm deleted the socket_exclude_localhost branch May 2, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants