-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auditbeat] Socket dataset: Exclude localhost by default #11993
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/secops |
andrewkroh
approved these changes
May 1, 2019
jenkins test this |
There is a test failure at https://travis-ci.org/elastic/beats/jobs/526384523#L748-L762. |
Thanks, fixed it. The cause was that without local sockets, the integration tests produce no data. CI is green now, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new configuration option
socket.include_localhost
to control if sockets from or to localhost/loopback should be included. It defaults tofalse
to reduce the large amount of data the dataset produces.I also took the opportunity to clean up, organize, and expand the unit tests - the tests are now
TestData
,TestOutbound
(connects togoogle.com:80
),TestListening
,TestLocalhost
, andTestLocalhostExcluded
.I also added a section
Implementation
to the docs with a blurb about how the socket dataset works on Linux.This is a breaking change since it changes what the socket dataset reports by default. It's worth doing in a minor release IMO since the dataset is quite noisy and the value of local connections is questionable. The current functionality can be restored by setting
socket.include_localhost: true
.