Add missing go generate lines for perfmon metricset #3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
10 tasks
andrewkroh
reviewed
Mar 30, 2017
| @@ -2,3 +2,6 @@ | |||
| Package perfmon collect windows performance counters. | |||
| */ | |||
| package perfmon | |||
|
|
|||
| // go:generate go tool cgo -godefs defs_windows.go > defs_windows_amd64.go | |||
There was a problem hiding this comment.
Please test this by running go generate.
From https://blog.golang.org/generate:
The comment must start at the beginning of the line and have no spaces between the // and the go:generate.
The space after the slash needs to be removed otherwise the command will not be executed.
|
I had generate these files without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the missing
go generatelines todoc.go.