Print unknown MongoDB opcodes #6255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When packetbeat encounters an unknown opcode it will print its value as a decimal integer instead of an empty string. Otherwise it will print the following line in the log: 2018/01/26 06:30:01.311175 mongodb_parser.go:42: ERR Unknown operation code: which is not very helpful. It has been changed to: 2018/01/26 06:30:01.311175 mongodb_parser.go:42: ERR Unknown operation code: (value=nnn)
|
Should we add a changelog entry for this? |
|
@exekias to me is just a little logging fix, don't think its worthy of a changelog entry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When packetbeat encounters an unknown opcode it will print its value as a decimal integer instead of an empty string. Otherwise, it prints the following line in the log:
2018/01/26 06:30:01.311175 mongodb_parser.go:42: ERR Unknown operation code:which is not very helpful. It has been changed to:
2018/01/26 06:30:01.311175 mongodb_parser.go:42: ERR Unknown operation code: (value=nnn)Related to #6191